Skip to content

ci(expo): Switch to maestro runner - #9264

Merged
wobsoriano merged 3 commits into
mainfrom
rob/maestro-runner
Jul 28, 2026
Merged

ci(expo): Switch to maestro runner#9264
wobsoriano merged 3 commits into
mainfrom
rob/maestro-runner

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jul 28, 2026 3:09pm
swingset Ready Ready Preview, Comment Jul 28, 2026 3:09pm

Request Review

@changeset-bot

changeset-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 419fbc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Jul 28, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9264

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9264

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9264

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9264

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9264

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9264

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9264

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9264

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9264

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9264

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9264

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9264

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9264

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9264

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9264

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9264

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9264

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9264

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9264

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9264

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9264

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9264

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9264

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9264

commit: 419fbc6

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 9bbe96c8-a647-4e21-bb16-de14de674b6c

📥 Commits

Reviewing files that changed from the base of the PR and between 6c10a4c and 419fbc6.

📒 Files selected for processing (1)
  • .changeset/nine-hoops-press.md
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)
  • clerk/clerk-docs (manual)
  • clerk/cloudflare-workers (manual)
  • clerk/cli (auto-detected)
  • clerk/clerk-ios (auto-detected)
  • clerk/clerk-android (auto-detected)

📝 Walkthrough

Walkthrough

The Expo native CI workflow provisions and caches maestro-runner, configures iOS and Android runner variables, and installs it conditionally. The flow script validates the binary and standardizes warmup and retry execution with output and failure artifacts. Failure handling scrubs test passwords from additional report formats, and a changeset records the update.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: switching Expo CI to maestro runner.
Description check ✅ Passed The description is a generic template, but it is still related to the PR and not off-topic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/expo-native-build.yml:
- Around line 217-243: The Install maestro-runner step must stop piping the
mutable remote installer directly into bash. Replace that flow with downloading
a pinned installer or artifact plus its required integrity metadata, fail if the
checksum file is unavailable, verify the downloaded content before execution,
and retain the existing retry and cached-binary behavior around the verified
installation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 817438b2-bf9c-49b0-8879-a03d2eb7610d

📥 Commits

Reviewing files that changed from the base of the PR and between 1397d63 and 52d9f28.

📒 Files selected for processing (2)
  • .github/workflows/expo-native-build.yml
  • integration/tests/expo-native/run-flows.sh
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)
  • clerk/clerk-docs (manual)
  • clerk/cloudflare-workers (manual)
  • clerk/cli (auto-detected)
  • clerk/clerk-ios (auto-detected)
  • clerk/clerk-android (auto-detected)

Comment on lines +217 to +243
- name: Cache maestro-runner
if: steps.keys.outputs.pk != ''
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4
with:
path: ~/.maestro
key: maestro-${{ runner.os }}-${{ env.MAESTRO_VERSION }}
path: ~/.maestro-runner
key: maestro-runner-${{ runner.os }}-${{ runner.arch }}-${{ env.MAESTRO_RUNNER_VERSION }}

- name: Install Maestro
- name: Install maestro-runner
if: steps.keys.outputs.pk != ''
# pipefail + binary check so a curl flake doesn't leave a missing
# binary that only surfaces later as exit-code-127.
run: |
set -o pipefail
if [ -x "$HOME/.maestro/bin/maestro" ]; then
echo "Using cached Maestro"
if [ -x "$HOME/.maestro-runner/bin/maestro-runner" ]; then
echo "Using cached maestro-runner"
else
installed=0
for i in 1 2 3; do
if curl -fLs --retry 3 --retry-delay 5 "https://get.maestro.mobile.dev" | MAESTRO_VERSION="$MAESTRO_VERSION" bash; then
if [ -x "$HOME/.maestro/bin/maestro" ]; then installed=1; break; fi
if curl -fsSL --retry 3 --retry-delay 5 "https://open.devicelab.dev/install/maestro-runner" |
bash -s -- --version "$MAESTRO_RUNNER_VERSION"; then
if [ -x "$HOME/.maestro-runner/bin/maestro-runner" ]; then installed=1; break; fi
fi
echo "Maestro install attempt $i failed (or binary missing); retrying"
echo "maestro-runner install attempt $i failed (or binary missing); retrying"
sleep 5
done
[ "$installed" = 1 ] || { echo "::error::Maestro install failed after 3 attempts"; exit 1; }
[ "$installed" = 1 ] || { echo "::error::maestro-runner install failed after 3 attempts"; exit 1; }
fi
echo "$HOME/.maestro/bin" >> "$GITHUB_PATH"
"$HOME/.maestro/bin/maestro" --version
echo "$HOME/.maestro-runner/bin" >> "$GITHUB_PATH"
"$HOME/.maestro-runner/bin/maestro-runner" --version

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

installer="$(mktemp)"
trap 'rm -f "$installer"' EXIT

curl --proto '=https' --tlsv1.2 -fsSL \
  'https://open.devicelab.dev/install/maestro-runner' \
  -o "$installer"

grep -nE 'sha256|sha512|checksum|signature|version|download' "$installer" || true

Repository: clerk/javascript

Length of output: 1003


🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

file=".github/workflows/expo-native-build.yml"
sed -n '200,250p' "$file"

printf '\n--- installer excerpt ---\n'
curl --proto '=https' --tlsv1.2 -fsSL 'https://open.devicelab.dev/install/maestro-runner' | sed -n '1,180p'

Repository: clerk/javascript

Length of output: 7243


Avoid piping the Maestro installer into bash The workflow still executes mutable remote code here, and the installer skips integrity checking when the .sha256 file is missing. Fetch a pinned artifact/installer and fail closed unless integrity metadata is present.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/expo-native-build.yml around lines 217 - 243, The Install
maestro-runner step must stop piping the mutable remote installer directly into
bash. Replace that flow with downloading a pinned installer or artifact plus its
required integrity metadata, fail if the checksum file is unavailable, verify
the downloaded content before execution, and retain the existing retry and
cached-binary behavior around the verified installation.

@wobsoriano
wobsoriano merged commit 4baa0ab into main Jul 28, 2026
56 checks passed
@wobsoriano
wobsoriano deleted the rob/maestro-runner branch July 28, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants